-
-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes undefined properties error in tests (closes issue #425) #432
Conversation
Sorry about the delay, @klougod. Is this update specifically for versions prior to craco 7? Are you able to recreate your original issue on the alpha version of craco? Because CRA 5 is over a year old now already, it may be best to stop supporting CRA 4 (craco 6) in favor of CRA 5 (craco 7). Many packages only support CRA 5 now anyways. I wouldn't want to merge your PR if it'll just be overwritten soon by the new update. If the intent is that this is just for craco 6 (which will soon stop being supported), I can go ahead and merge and release a new craco 6 version. |
I'm having this problem with craco 6 but i'll surely try to reproduce it with craco 7, soon i'll give an update here |
@dilanx Hi, As I expected this only happens in craco version 6, the intent for this PR would be to fix it only for the version 6, in my case and many others it would help since I cant fully update to craco 7. Thanks |
Okay sounds good, I'll merge your changes and release a patch for version 6. |
No description provided.